Fix nil output <a> name attribute conversion#4
Open
logwolvy wants to merge 1 commit intosoundasleep:masterfrom
Open
Fix nil output <a> name attribute conversion#4logwolvy wants to merge 1 commit intosoundasleep:masterfrom
logwolvy wants to merge 1 commit intosoundasleep:masterfrom
Conversation
Owner
|
Thank you for the PR! Can you please include a test case that illustrates the change? |
Author
|
Hi @soundasleep, I think we shouldn't convert 'a' tags to markdown like syntax when they have name attributes? Example The actual behavior works well when the 'a' tag has an href attribute but for name attributes, it shouldn't add the square brackets. What do you think? |
Owner
|
I think your proposal is totally fine. If an |
956ec37 to
3330c3f
Compare
gendosu
added a commit
to pocake/html2text_ruby
that referenced
this pull request
Apr 25, 2023
update version.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The attribute described(link below) was being converted incorrectly for certain pages I tried.
https://www.w3schools.com/tags/att_a_name.asp
I created this gist based on the page I was trying to convert and before fix I was getting -
I admit this is really badly written non-html5 doc, but I really need to convert this for a project in production. After this fix, these conversions are fine.
Kindly, merge this fix. Thanks!