Fixed Function in class-setup-wizard.php#2519
Open
DAnn2012 wants to merge 5 commits intosovware:developmentfrom
Open
Fixed Function in class-setup-wizard.php#2519DAnn2012 wants to merge 5 commits intosovware:developmentfrom
DAnn2012 wants to merge 5 commits intosovware:developmentfrom
Conversation
Collaborator
FILE: includes/classes/class-setup-wizard.phpFOUND 1 ERROR AFFECTING 1 LINE1034 | ERROR | All output should be run through an escaping function (see the |
Collaborator
|
Please describe the issue in this way. |
Author
|
Hello @Armanul46 When you can, could you take a look at this PR of mine? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Description
Fixed Function in class-setup-wizard.php
Refactored localization logic for step indicator
This update improves the way the step indicator string is localized. Previously, the code used
esc_html_e()with asprintf()wrapper, which could lead to issues with proper translation of the entire sentence structure. The new implementation usesprintf()withesc_html__(), allowing translators to work with the full sentence'Step %s of 4'rather than piecing together fragments.Before:
After:
This change ensures better internationalization support and cleaner separation of translation and output logic.
Checklist