fix: Fix Thread deadlock because of the join() in GitHubClient#229
Merged
fix: Fix Thread deadlock because of the join() in GitHubClient#229
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #229 +/- ##
============================================
- Coverage 77.42% 77.41% -0.01%
- Complexity 421 433 +12
============================================
Files 60 60
Lines 1373 1368 -5
Branches 59 60 +1
============================================
- Hits 1063 1059 -4
+ Misses 267 265 -2
- Partials 43 44 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Abhi347
force-pushed
the
fix/fix-thread-deadlock-in-client
branch
from
fdf6449 to
b6de3b0
Compare
Abhi347
commented
Apr 9, 2025
Comment on lines
+183
to
+186
| assertThat(ex.getCause().getMessage(), is("Could not generate access token for github app")); | ||
|
|
||
| assertThat(ex.getCause(), is(notNullValue())); | ||
| assertThat(ex.getCause().getMessage(), startsWith("Got non-2xx status 500 when getting an access token from GitHub")); | ||
| assertThat(ex.getCause().getCause(), is(notNullValue())); | ||
| assertThat(ex.getCause().getCause().getCause().getMessage(), startsWith("Got non-2xx status 500 when getting an access token from GitHub")); |
Contributor
Author
There was a problem hiding this comment.
The Exceptions are wrapped in extra RuntimeExceptions now. Not sure if that's gonna be a problem or not. Ideally we should have a specific Exception class to deal with AccessToken Exceptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
join()on fetching access tokens can cause thread deadlock when there are many requests in the pool. Making the entire method chain async should fix this.