Feat/add authenticated app endpoint#251
Merged
dennisgranath merged 4 commits intospotify:masterfrom Nov 5, 2025
Merged
Conversation
Replaces Optional.get() calls with requireOwner() helper that provides clear error messages when owner-dependent methods are called on app-level clients without owner context.
javoire
commented
Oct 23, 2025
| + "Use GitHubClient.createOrganisationClient(owner).createGithubAppClient() " | ||
| + "or GitHubClient.createRepositoryClient(owner, repo).createGithubAppClient() " | ||
| + "instead of GitHubClient.createGithubAppClient()")); | ||
| } |
Member
Author
There was a problem hiding this comment.
another option is another Class (GithubAppClient?). But then I'd prob rename this class to GithubAppInstallationClient which would be a breaking change
at least this way its hard to accidentally call one of the existing methods without the owner
This comment was marked as outdated.
This comment was marked as outdated.
Abhi347
approved these changes
Nov 4, 2025
Member
Author
|
Thx @Abhi347, I can't merge so whenver you get a change :) 🙏🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the GitHub Apps API GET /app endpoint which returns information about the authenticated GitHub App.
Changes: