-
-
Notifications
You must be signed in to change notification settings - Fork 88
Fix all size warnings calls to ggplot2 (deprecated at 3.4.0).
#414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ted arg size and added linewidth as new preferred arg where it made sense.
|
Thank you! I definitely think we should change all internal cases of this. For the user-facing arguments, is there a reason only to do this for plots in |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #414 +/- ##
=======================================
Coverage 98.61% 98.62%
=======================================
Files 35 35
Lines 5792 5798 +6
=======================================
+ Hits 5712 5718 +6
Misses 80 80 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No, we should probably do that. But note that some |
|
Do mind removing the the deprecations in the ppc-censoring functions from this PR? Let's handle internal changes in this PR and then we can do the user-facing changes separately. I think that will make it easier to review and reason about. Is that ok with you? Thanks again for working on this! |
|
No problem! Removed all deprecation stuff. |
|
Thank you! Looks good, merging now. |
This PR fixes all the
sizewarnings that ggplot2 threw (see also issue #408) by replacing them withlinewidth.I also added
sizeas deprecated inppc_km_overlay()andp_overlay()usinglifecycle::deprecated.