Skip to content

Conversation

@zastrowm
Copy link
Member

Description

Add decision record for flat namespaces/modules for exports. This came about as a result of strands-agents/sdk-python#1498 (comment)


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dbschmigelski
Copy link
Member

Documentation Deployment Complete

Your documentation preview has been successfully deployed!

Preview URL: https://d3ehv1nix5p99z.cloudfront.net/pr-447/


### Rationale

Fewer imports are simpler to use and more discoverable when using IDE autocompletion & documentation. It also aligns with the Python ethos "Flat is better than nested" (PEP 20 - The Zen of Python).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General question: Are these decisions tied to python, or should they also be used in other language development? If its just python, can we tag them somehow?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It applies to both - I will update that to make it more clear

Copy link
Member

@dbschmigelski dbschmigelski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but can we align on some commit prefix here

like

decision: ...
or
feat(decision): ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants