-
Notifications
You must be signed in to change notification settings - Fork 154
feat: Add decision record for flat namespaces #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Documentation Deployment CompleteYour documentation preview has been successfully deployed! Preview URL: https://d3ehv1nix5p99z.cloudfront.net/pr-447/ |
|
|
||
| ### Rationale | ||
|
|
||
| Fewer imports are simpler to use and more discoverable when using IDE autocompletion & documentation. It also aligns with the Python ethos "Flat is better than nested" (PEP 20 - The Zen of Python). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General question: Are these decisions tied to python, or should they also be used in other language development? If its just python, can we tag them somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It applies to both - I will update that to make it more clear
dbschmigelski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but can we align on some commit prefix here
like
decision: ...
or
feat(decision): ...
Description
Add decision record for flat namespaces/modules for exports. This came about as a result of strands-agents/sdk-python#1498 (comment)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.