node lives in utf-8, GeoIP is in ISO-8859-1 ... convert#3
Open
postwait wants to merge 13 commits intostrange:masterfrom
Open
node lives in utf-8, GeoIP is in ISO-8859-1 ... convert#3postwait wants to merge 13 commits intostrange:masterfrom
postwait wants to merge 13 commits intostrange:masterfrom
Conversation
Build error fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch converts the output GeoIP string values from their ISO-8859-1 native form to utf-8 which is more suitable for general node use.