Fixes #371 - throttle using strategy input should cache results (#372) #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the Switcher Client SDK to version 2.5.1 and fixes throttle feature when using Strategy inputs. The issue was that the mapper wasn't assigning the entries (Strategy inputs) to the copied response object, which caused the cache to have invalid entries.
Refactoring and Code Organization:
KEY,SHOW_REASON,BYPASS_METRIC) fromSwitcherRequestto theClientWSinterface, centralizing their definitions and usage. ([[1]](https://github.com/switcherapi/switcher-client-java/pull/373/files#diff-50b643c046fcf01d65f95fbeb497f0da0daaf755828ef185e1a3bd8381b2b710L23-L28),[[2]](https://github.com/switcherapi/switcher-client-java/pull/373/files#diff-73f7c13916e88a9d34ab504ec707b33a7bfee0360c8ee1277bfdec7dd7ae0fceR45-R59))ClientWSImplto reference the constants fromClientWSinstead ofSwitcherRequest, ensuring consistency and reducing coupling. ([src/main/java/com/switcherapi/client/remote/ClientWSImpl.javaL50-R51](https://github.com/switcherapi/switcher-client-java/pull/373/files#diff-a39c02177032671f84fcce967ebed4fcf4003052d4f9ca76eb5423f7755d1219L50-R51))