Conversation
alt-graph
force-pushed
the
migrate_to_gul17
branch
from
a6afb33 to
d2db406
Compare
alt-graph
requested review from
Finii,
MissPeppermintPatty,
Copilot,
ohensler and
wyrnat
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the codebase from using GUL14 to GUL17 as the base library. The key changes include updating header includes and using statements from gul14 to gul17, updating dependency information in build and wrap files, and extending copyright years where needed.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_Repository.cc | Updated includes and function calls from gul14 to gul17 |
| tests/test_Remote.cc | Removed gul14 includes and using directives |
| subprojects/libgul14.wrap | Removed old wrap configuration for gul14 |
| subprojects/gul17.wrap | Added new wrap configuration for gul17 |
| src/wrapper_functions.cc | Updated includes and commented logging from gul14 to gul17 |
| src/Repository.cc | Replaced gul14 with gul17 includes and changed get_remote return type |
| src/Remote.cc | Updated includes and using directives from gul14 to gul17 |
| meson.build | Replaced dependency references from libgul14 to gul17 |
| include/libgit4cpp/Repository.h | Updated includes and documentation headers from gul14 to gul17 |
| include/libgit4cpp/Remote.h | Updated includes and removed gul14 wrappers |
| debian/control | Updated build dependency from gul14-dev to gul17-dev |
| LIBNO | Bumped version number reflecting the migration update |
This PR replaces GUL14 as a base library by GUL17. Most of the modifications are done automatically. Signed-off-by: Lars Froehlich <lars.froehlich@desy.de>
Signed-off-by: Lars Froehlich <lars.froehlich@desy.de>
alt-graph
force-pushed
the
migrate_to_gul17
branch
from
d2db406 to
bccb1c3
Compare
[why] The Github runners are no longer available. Signed-off-by: Lars Froehlich <lars.froehlich@desy.de>
Finii
approved these changes
Jun 5, 2025
Contributor
Finii
left a comment
Finii
left a comment
There was a problem hiding this comment.
Can not find any small thing to lament about 😒
Member
Author
|
Thanks, @Finii! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces GUL14 as a base library by GUL17. Most of the modifications are done automatically.