WIP: Settings API fixes and improvements#104
Open
rogerfachini wants to merge 3 commits intotechninja:v3from
Open
WIP: Settings API fixes and improvements#104rogerfachini wants to merge 3 commits intotechninja:v3from
rogerfachini wants to merge 3 commits intotechninja:v3from
Conversation
rogerfachini
changed the title
rogerfachini
changed the title
Author
|
Work in progress: adding support for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When enabling debug mode via the settings API, it would crash with
TypeError: req.body is not iterable. The first commit addresses this issue.The runner's settings are first initialized from global settings when the
runner.readymessage is received. When the settings are updated via the API, these changes are not propagated to the runner's settings.