set repository priority from plugin vars #4505
Open
+80
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaibhavdaren
changed the title
LecrisUT
reviewed
Jan 19, 2026
vaibhavdaren
added
plugin | artifact
vaibhavdaren
commented
Jan 20, 2026
vaibhavdaren
force-pushed
the
vaibhav-priority-from-plugin-vars
branch
2 times, most recently
from
b84e1b9 to
aff6b44
Compare
vaibhavdaren
force-pushed
the
vaibhav-priority-from-plugin-vars
branch
2 times, most recently
from
7795993 to
d96954e
Compare
The artifact provider priority is now passed through the constructor instead of being hardcoded. This allows providers to use the priority value from TMT_PLUGIN_PREPARE_ARTIFACT_PRIORITY environment variable or --priority option via self.data.priority.
Reorder parameters in ArtifactProvider and all subclasses to have logger as the last parameter, following the convention used elsewhere in the codebase. Update all callers and unit tests accordingly.
- Rename PrepareArtifactData.priority to default_repository_priority - Update CLI option to --default-repository-priority - Rename provider parameter from priority to repository_priority - Update all provider subclasses and tests - Fix metavar to PRIORITY for better documentation display - Add environment variable documentation in help string
vaibhavdaren
force-pushed
the
vaibhav-priority-from-plugin-vars
branch
from
d96954e to
45afc9a
Compare
happz
added
the
status | blocking other work
vaibhavdaren
added
the
ci | full test
LecrisUT
approved these changes
Jan 22, 2026
Contributor
LecrisUT
left a comment
LecrisUT
left a comment
There was a problem hiding this comment.
Just one inconsistency spotted
vaibhavdaren
force-pushed
the
vaibhav-priority-from-plugin-vars
branch
from
091dc5c to
43bbeb2
Compare
happz
reviewed
Jan 22, 2026
| provide: | ||
| $ref: "/schemas/common#/definitions/one_or_more_strings" | ||
|
|
||
| default_repository_priority: |
Contributor
There was a problem hiding this comment.
Specification keys are always using - to separate words.
Suggested change
| default_repository_priority: | |
| default-repository-priority: |
happz
reviewed
Jan 22, 2026
| help=""" | ||
| Default priority for created artifact repositories. Lower values mean | ||
| higher priority in package managers. Default: 50. Also uses environment | ||
| variable ``TMT_PLUGIN_PREPARE_ARTIFACT_DEFAULT_REPOSITORY_PRIORITY``. |
Contributor
There was a problem hiding this comment.
Please, don't mention the default value, it will be displayed by tmt and rendered into HTML docs automatically. Also, I advise against mentioning the environment variable, because pretty much all CLI options can be specified via environment variables, and this one is not special enough to deserve its own to be mentioned explicitly. See https://tmt--4505.org.readthedocs.build/en/4505/plugins/prepare.html#id1, it's rendered into HTML, and once I'm done with #4472, we can enable display of envvars in CLI help as well.
Contributor
|
PR name would deserve an update, to better reflect the change to something like "Accept default repository priority for repositories created by prepare/artifact" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist