Open
Conversation
Contributor
|
@distalx thanks for putting this together. Would you be interested in being a collaborator on the repo and taking over maintenance? Will have to figure out how to allow you to do pushes to Atmosphere... |
Author
|
@rglover, Thanks for the quick response. |
Author
|
For me all tests are green.
Keeping a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a list of things that could be improved.
jQueryto vanilla JS.fourseven:scssto latest.FontAwesomein favour ofBootstrap Icons!?- [ ] RemovejQueryfrom tests.The latest version of FontAwesome requires the creation of an account with them just to use the free version of it. I've been using the Bootstrap Icons for a while and I believe they can be a good replacement.
I haven't removed
jQueryfrom the tests. Just so you can test the changes against them. For me, all tests are passing.