Skip to content

ASoC: SOF: Intel: hda: add SDCA property check #5652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
macchian wants to merge 1 commit into
base: topic/sof-dev
Choose a base branch
from
Open

ASoC: SOF: Intel: hda: add SDCA property check #5652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions sound/soc/sof/intel/hda.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1138,6 +1138,12 @@ static bool is_endpoint_present(struct sdw_slave *sdw_device,
{
int i;

/* If SDCA is not present, assume the endpoint is present */
if (!sdw_device->sdca_data.interface_revision) {
dev_warn(&sdw_device->dev, "SDCA properties not found in BIOS\n");
Copy link
Member

@lgirdwood lgirdwood Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably say which endpoint to assist with integration/debug.

Copy link
Collaborator

@bardliao bardliao Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lgirdwood If no sdca_data.interface_revision found means there is no SDCA properties at all. It is not just missing a specific endpoint. Also, we can't tell if an endpoint is missed or not present.

return true;
}

for (i = 0; i < sdw_device->sdca_data.num_functions; i++) {
if (dai_type == dai_info->dais[i].dai_type)
return true;
Expand Down
Loading