ASoC: Intel: add I2S function topology support #5657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each function topology has its own NHLT blob sections. And we need to look for the matching blob from all the NHLT blobs. Also, move the error log to where the blob can't be found from all the NHLT blobs. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
The existing code supports get_function_tplg_files callback for SoundWire machine driver only. Some common sections can be used for other machines. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
…et_tplg_files The Intel SOF SDW machine drive also supports I2S interface. Add related supports for the sof_sdw_get_tplg_files() callback. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
… I2S machines Add sof_i2s_get_tplg_files() callback for Intel SOF I2S machines. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Use sof_i2s_get_tplg_files() for SOF es83x6 machines. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
bardliao
requested review from
dbaluta,
kv2019i,
lgirdwood and
plbossart
as code owners
ujfalusi
reviewed
Jan 28, 2026
Collaborator
ujfalusi
left a comment
ujfalusi
left a comment
There was a problem hiding this comment.
only checked the first patch
| } | ||
|
|
||
| dev_err(dev, "%s: No match for SSP%d in NHLT table\n", __func__, | ||
| dev_dbg(dev, "%s: No match for SSP%d in NHLT table\n", __func__, |
Collaborator
There was a problem hiding this comment.
I would have this as separate patch?
we are also going to look for DMIC blobs in several nhlt, so change those prints as well?
| struct snd_ipc4_nhlt *nhlt; | ||
|
|
||
| ipc4_data->nhlt = intel_nhlt_init(sdev->dev); | ||
| nhlt->nhlt = intel_nhlt_init(sdev->dev); |
Collaborator
There was a problem hiding this comment.
Hrm, does this works? nhlt is a pointer, which has not been initialized. nhlt->nhlt dereferencing a random memory and stores a pointer in random place, corrupting something?
| ipc4_data->nhlt = intel_nhlt_init(sdev->dev); | ||
| nhlt->nhlt = intel_nhlt_init(sdev->dev); | ||
|
|
||
| list_add(&nhlt->list, &ipc4_data->nhlt_list); |
| struct snd_ipc4_nhlt { | ||
| struct list_head list; | ||
| void *nhlt; | ||
| size_t nhlt_size; |
| size_t nhlt_size; | ||
| }; | ||
|
|
||
|
|
| channel_count, sample_rate, | ||
| dir, dev_type); | ||
| if (cfg) | ||
| break; |
Collaborator
There was a problem hiding this comment.
goto out; and remove the cfg check after the loop?
| struct snd_ipc4_nhlt *tplg_nhlt; | ||
|
|
||
| /* Get the nhlt from topology manifest*/ | ||
| tplg_nhlt = kzalloc(sizeof(*tplg_nhlt), GFP_KERNEL); |
Collaborator
There was a problem hiding this comment.
this is what is missing in hda-dai.c!
Collaborator
There was a problem hiding this comment.
but you need devm_kzalloc() to leak memory..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, function topology is only used by the SoundWire machines. Extend the support to the I2S machines.