Conversation
In case of a custom path used for Bitters installation, `remove` or `reset` commands were useless as not aware of this path.
Running `bitters install --path foo` outputs "Bitters files installed to "foo/base/base" when it should show "foo/base" only.
There was a problem hiding this comment.
Do not write to stdout. Use Rails' logger if you want to log.
There was a problem hiding this comment.
We're not in rails, so this is fine
There was a problem hiding this comment.
I would remove the trailing slash, if you specify the path to be custom_path/ it will be printed as ...installed to custom_path//
There was a problem hiding this comment.
Not really, as the path would be custom_path/base, due to
bitters/lib/bitters/generator.rb
Line 56 in 8e00402
This diff line (from the 2nd commit), only fixes the CLI output when running for example
bitters install --path foo. It outputs Bitters files installed to foo/base/base when it should show foo/base.
|
Any updates guys? Anything more I can do to help with this? |
|
@teoljungberg any sense on next steps/recommendations? |
|
I would still like to see tests for thi.s |
|
@mehlah Hi! Are you able to add tests to this PR? |
Allow
bitters resetandbitters removeto take--pathoption