[v1.41] Update nodeSet naming #4390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rene-dekker
approved these changes
Jan 27, 2026
The upgrade of k8s.io/apimachinery to v0.34.3 changed how k8s objects serialize, causing the same PVC template to produce different hashes across tigera-operator versions. Since NodeSet names are derived from PVC template hashes, this triggered unnecessary StatefulSet recreation during Calico Enterprise upgrades, leading to slow upgrades (dynamic provisioning) or stalled upgrades (static provisioning with no available PVs). This change replaces hash-based NodeSet naming with logic that retains the existing name when the PVC template matches LogStorage configuration, and uses a random string when a new name is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
picks #4378
Description
Release Note
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.