Merged
Conversation
Docker supports either CGroups v1 or v2 and while running under v2 the memory stat details change slightly. To account for FS cache we need to subtract out `memory_stats.stats.inactive_file` instead of `memory_stats.stats.total_cache` under v1. We found this despondency when running the latest `dockerd` on Debian Bullseye.
This was referenced Jan 26, 2026
Moving to GitHub Actions for this
- Introduce requirements file - Add Makefile
martialblog
force-pushed
the
release/v2-3-0
branch
from
9f24736 to
75bc72c
Compare
This makes for a more readable output when there are many containers Co-authored-by: Dennis Mücklich <58838393+dmueckli@users.noreply.github.com>
This was referenced Jan 26, 2026
- Also removes erroneous debug print
I think this was probably a copy paste error. Fixing it will change the default behavior so that performance data is show. The original can be restored by simply using the --no-performance flag
martialblog
force-pushed
the
release/v2-3-0
branch
from
4f58fd3 to
165d5ca
Compare
Co-authored-by: mlu <marek.luenenschloss@qplix.com>
Collaborator
Author
|
Hi @timdaman I can't merge this due to the old CI settings that won't run anymore. Can you override this? Thanks |
timdaman
approved these changes
Jan 27, 2026
Owner
timdaman
left a comment
timdaman
left a comment
There was a problem hiding this comment.
Thank you for bringing the forward nearly a decade.
|
|
||
| global no_performance | ||
| no_performance = args.no_ok | ||
| no_performance = args.no_performance |
Owner
There was a problem hiding this comment.
Doh, that is a silly bug. Thanks for fixing.
Collaborator
Author
There was a problem hiding this comment.
Oh no worries. I've made my fair share of copy-paste mistakes
Owner
Done. |
Collaborator
Author
|
Cool Thanks. I will have a look over the remaining PRs soon and then bump the version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch to prepare the new release.
Includes
Fixes #83 #81 #91 #93