Open
Conversation
Author
|
Regarding the README, there is one more thing I noticed though I don't want to make a decision for a fix and so will let you handle it: Composer is mentioned in the requirements, but it is bundled with this repository. As such, the Composer binary should be removed (which would be standard practice, as it is outdated (v2.8.3 vs current @ v2.9.5)) or the requirement should be updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I was browsing the source to try and get a handle on Lara's API and noticed the README PHP version requirement states >= 7.4 while
composer.jsonenforced >=5.6.0, so I thought I'd PR a fix reflective of the documentation.I haven't run or tested this, I just wanted to bring it to your attention and if this fix is acceptable, great.