Add docs and warning around the use of latest key version alias#694
Merged
AlCutter merged 1 commit intotransparency-dev:mainfrom Feb 3, 2026
Merged
Conversation
phbnf
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it explicit that using the
latestversion alias for secret in Secret Manager is not recommended.Adds text to the GCP README explaining that keys are stored in Secret Manager, along with a warning about the
latestalias.Removes the unusual check that the requested key secret name is the same as the returned secret name, and replaces with a more explicit test for
latestlogging a warning if present.Addresses #689