Modified 'lib/server.js' to deal with IP addresses correctly.#26
Open
AaronNGray wants to merge 1 commit intotrevoro:masterfrom
Open
Modified 'lib/server.js' to deal with IP addresses correctly.#26AaronNGray wants to merge 1 commit intotrevoro:masterfrom
AaronNGray wants to merge 1 commit intotrevoro:masterfrom
Conversation
trevoro
requested changes
Mar 19, 2018
| if (!ip_version) | ||
| self.emit('error', new Error("Invalid IP address")); | ||
|
|
||
| this._socket = dgram.createSocket((ip_version == 4) ? 'udp4' : 'udp6'); |
Owner
There was a problem hiding this comment.
Can you move this logic to a constant / variable that sits higher up?
No sense to repeat it twice. After that happy to merge. :)
This was referenced Oct 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added code to check IP address is valid and fixed IPv4 problem in issues #16, #20, and #24.