Skip to content

Conversation

@HavenDV
Copy link
Contributor

@HavenDV HavenDV commented Jun 5, 2025

Summary by CodeRabbit

  • Documentation
    • Updated descriptions to clarify that the "universal" speech model is now used by default when no model is specified.
    • Adjusted default value references for the speech model to reflect this change.

@coderabbitai
Copy link

coderabbitai bot commented Jun 5, 2025

Walkthrough

The OpenAPI specification was updated to change the default speech model from "best" to "universal" in the TranscriptOptionalParams schema and to clarify the description for the speech_model property in both TranscriptOptionalParams and Transcript schemas. No functional or structural changes were made.

Changes

File Change Summary
src/libs/AssemblyAI/openapi.yaml Updated speech_model property: changed default from "best" to "universal" and revised descriptions in two schemas.

Poem

A hop and a skip, we change with care,
"Universal" is now the model we share.
No more "best" in our YAML to see,
Just clearer words for you and me.
🐇✨


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@HavenDV HavenDV enabled auto-merge (squash) June 5, 2025 21:18
@HavenDV HavenDV merged commit 4024476 into main Jun 5, 2025
3 of 4 checks passed
@HavenDV HavenDV deleted the bot/update-openapi_202506052118 branch June 5, 2025 21:19
@coderabbitai coderabbitai bot changed the title feat:@coderabbitai feat:Update default speech model to universal and clarify speech_model descriptions Jun 5, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/libs/AssemblyAI/openapi.yaml (1)

1269-1270: Change default to “universal” is correct
The updated description and default value in TranscriptOptionalParams now correctly specify that omitting or null-setting speech_model will use the universal model.

Consider updating the example under TranscriptOptionalParams to demonstrate omission of speech_model (relying on the new default) instead of explicitly setting it to null.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4734f1f and fae3f72.

⛔ Files ignored due to path filters (68)
  • src/libs/AssemblyAI/Generated/AssemblyAI..JsonSerializerContext.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.AnyOf2.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.AudioIntelligenceModelStatus.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.AudioIntelligenceModelStatusNullable.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.EntityType.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.EntityTypeNullable.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.ErrorStatus.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.ErrorStatusNullable.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.LemurActionItemsParams.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.LemurActionItemsResponse.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.LemurModel.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.LemurModelNullable.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.LemurQuestionAnswerParams.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.LemurQuestionAnswerResponse.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.LemurResponse.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.LemurStringResponse.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.LemurSummaryParams.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.LemurSummaryResponse.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.LemurTaskParams.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.LemurTaskResponse.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.OneOf2.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.PiiPolicy.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.PiiPolicyNullable.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.RedactPiiAudioQuality.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.RedactPiiAudioQualityNullable.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.RedactedAudioNotification.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.RedactedAudioStatus.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.RedactedAudioStatusNullable.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.Sentiment.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.SentimentNullable.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.SpeechModel.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.SpeechModelNullable.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.SubstitutionPolicy.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.SubstitutionPolicyNullable.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.SubtitleFormat.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.SubtitleFormatNullable.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.SummaryModel.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.SummaryModelNullable.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.SummaryType.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.SummaryTypeNullable.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.TranscriptBoostParam.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.TranscriptBoostParamNullable.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.TranscriptLanguageCode.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.TranscriptLanguageCodeNullable.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.TranscriptParams.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.TranscriptReadyStatus.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.TranscriptReadyStatusNullable.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.TranscriptStatus.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.TranscriptStatusNullable.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.TranscriptWebhookNotification.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.JsonSerializerContextTypes.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.LeMURClient.GetLemurResponse.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.LeMURClient.LemurQuestionAnswer.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.LeMURClient.LemurSummary.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.LeMURClient.LemurTask.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.LeMURClient.PurgeLemurRequestData.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.Models.Transcript.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.Models.TranscriptOptionalParams.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.TranscriptClient.CreateTranscript.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.TranscriptClient.DeleteTranscript.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.TranscriptClient.GetRedactedAudio.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.TranscriptClient.GetSubtitles.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.TranscriptClient.GetTranscript.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.TranscriptClient.GetTranscriptParagraphs.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.TranscriptClient.GetTranscriptSentences.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.TranscriptClient.ListTranscripts.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.TranscriptClient.UploadFile.g.cs is excluded by !**/generated/**
  • src/libs/AssemblyAI/Generated/AssemblyAI.TranscriptClient.WordSearch.g.cs is excluded by !**/generated/**
📒 Files selected for processing (1)
  • src/libs/AssemblyAI/openapi.yaml (2 hunks)
🔇 Additional comments (1)
src/libs/AssemblyAI/openapi.yaml (1)

2619-2621:

Details

❓ Verification inconclusive

Clarify transcript response mapping for null speech_model
The description in the Transcript schema now makes it clear that a null speech_model means universal was applied. Keeping the default as null is appropriate.

Verify that client-side deserializers treat a null speech_model as universal by running:


🏁 Script executed:

#!/bin/bash
# Search for handling of null speech_model in client SDK code
rg -R "speech_model" -t ts,js,py --context 3

Length of output: 449


Let's re-run the search using the correct ripgrep flags to locate any client‐side handling of a null speech_model:


🏁 Script executed:

#!/bin/bash
# Search for handling of null speech_model in client SDK code
rg "speech_model" -t ts -t js -t py -C3

Length of output: 188


Verify client‐side fallback for null speech_model
I ran a search across the SDK code and didn’t find any deserializer or runtime logic that maps null to "universal". Please manually confirm that your generated client code treats a null speech_model as "universal", or add a fallback in the SDK so it matches the OpenAPI contract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants