-
-
Notifications
You must be signed in to change notification settings - Fork 1
feat:Update default speech model to universal and clarify speech_model descriptions #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe OpenAPI specification was updated to change the default speech model from "best" to "universal" in the Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/libs/AssemblyAI/openapi.yaml (1)
1269-1270: Change default to “universal” is correct
The updated description and default value inTranscriptOptionalParamsnow correctly specify that omitting or null-settingspeech_modelwill use theuniversalmodel.Consider updating the example under
TranscriptOptionalParamsto demonstrate omission ofspeech_model(relying on the new default) instead of explicitly setting it tonull.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (68)
src/libs/AssemblyAI/Generated/AssemblyAI..JsonSerializerContext.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.AnyOf2.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.AudioIntelligenceModelStatus.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.AudioIntelligenceModelStatusNullable.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.EntityType.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.EntityTypeNullable.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.ErrorStatus.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.ErrorStatusNullable.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.LemurActionItemsParams.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.LemurActionItemsResponse.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.LemurModel.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.LemurModelNullable.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.LemurQuestionAnswerParams.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.LemurQuestionAnswerResponse.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.LemurResponse.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.LemurStringResponse.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.LemurSummaryParams.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.LemurSummaryResponse.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.LemurTaskParams.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.LemurTaskResponse.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.OneOf2.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.PiiPolicy.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.PiiPolicyNullable.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.RedactPiiAudioQuality.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.RedactPiiAudioQualityNullable.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.RedactedAudioNotification.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.RedactedAudioStatus.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.RedactedAudioStatusNullable.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.Sentiment.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.SentimentNullable.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.SpeechModel.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.SpeechModelNullable.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.SubstitutionPolicy.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.SubstitutionPolicyNullable.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.SubtitleFormat.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.SubtitleFormatNullable.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.SummaryModel.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.SummaryModelNullable.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.SummaryType.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.SummaryTypeNullable.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.TranscriptBoostParam.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.TranscriptBoostParamNullable.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.TranscriptLanguageCode.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.TranscriptLanguageCodeNullable.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.TranscriptParams.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.TranscriptReadyStatus.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.TranscriptReadyStatusNullable.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.TranscriptStatus.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.TranscriptStatusNullable.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.TranscriptWebhookNotification.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.JsonSerializerContextTypes.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.LeMURClient.GetLemurResponse.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.LeMURClient.LemurQuestionAnswer.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.LeMURClient.LemurSummary.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.LeMURClient.LemurTask.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.LeMURClient.PurgeLemurRequestData.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.Models.Transcript.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.Models.TranscriptOptionalParams.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.TranscriptClient.CreateTranscript.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.TranscriptClient.DeleteTranscript.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.TranscriptClient.GetRedactedAudio.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.TranscriptClient.GetSubtitles.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.TranscriptClient.GetTranscript.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.TranscriptClient.GetTranscriptParagraphs.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.TranscriptClient.GetTranscriptSentences.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.TranscriptClient.ListTranscripts.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.TranscriptClient.UploadFile.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.TranscriptClient.WordSearch.g.csis excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/AssemblyAI/openapi.yaml(2 hunks)
🔇 Additional comments (1)
src/libs/AssemblyAI/openapi.yaml (1)
2619-2621:Details
❓ Verification inconclusive
Clarify transcript response mapping for null
speech_model
The description in theTranscriptschema now makes it clear that anullspeech_modelmeansuniversalwas applied. Keeping the default asnullis appropriate.Verify that client-side deserializers treat a null
speech_modelasuniversalby running:
🏁 Script executed:
#!/bin/bash # Search for handling of null speech_model in client SDK code rg -R "speech_model" -t ts,js,py --context 3Length of output: 449
Let's re-run the search using the correct ripgrep flags to locate any client‐side handling of a null
speech_model:
🏁 Script executed:
#!/bin/bash # Search for handling of null speech_model in client SDK code rg "speech_model" -t ts -t js -t py -C3Length of output: 188
Verify client‐side fallback for null
speech_model
I ran a search across the SDK code and didn’t find any deserializer or runtime logic that mapsnullto"universal". Please manually confirm that your generated client code treats anullspeech_modelas"universal", or add a fallback in the SDK so it matches the OpenAPI contract.
Summary by CodeRabbit