Modify generate.sh to take a dynamic number of GPUs as input#24
Open
aman2304 wants to merge 1 commit intouclaml:mainfrom
Open
Modify generate.sh to take a dynamic number of GPUs as input#24aman2304 wants to merge 1 commit intouclaml:mainfrom
aman2304 wants to merge 1 commit intouclaml:mainfrom
Conversation
Author
|
@angelahzyuan could you take a look at this when you have time? Would love to merge it if it looks good to you. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Data generation requires exactly 8 GPUs to be present. This doesn't make the code run properly on machines with less than 8 GPUs (for instance, I am using 4 H100s)
Changes
Changed
generate.shso that the user can specify the number of GPUs as input, with a minimum number of 1. The default is still set to 8 GPUs and the number will change only if the--gpuparameter is specified