-
Notifications
You must be signed in to change notification settings - Fork 17
🐛 Fix stacked plots functionality by ensuring multiple output var… #4068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…es are handled correctly
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4068 +/- ##
==========================================
- Coverage 46.60% 46.56% -0.05%
==========================================
Files 122 124 +2
Lines 28711 28981 +270
==========================================
+ Hits 13381 13495 +114
- Misses 15330 15486 +156 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timothy-nunn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you give me an example of the bug this fixes please (an MFile + commands to run)... its not immediately obvious what the problem was and how this fixes it.
process/io/plot_scans.py
Outdated
| sharex=True, | ||
| ) | ||
| fig.subplots_adjust(hspace=0.0) | ||
| pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rewrite this if statement to avoid just having a pass
This pull request refactors the logic for handling stacked plots in the
mainfunction ofprocess/io/plot_scans.py. The main improvement is to ensure that subplots for stacked plots are created only once, and only when needed, thereby fixing potential issues with subplot creation and improving code clarity.Plotting logic improvements:
fig, axs = plt.subplots(...)) from the outer loop to occur only once, at the first relevant iteration, preventing redundant subplot creation and related errors.passstatement, since subplot creation is now handled inside the plotting logic.ValueErrorif stacked plots are requested with only one output variable, ensuring proper usage and error handling.…iables are handled correctlyDescription
Checklist
I confirm that I have completed the following checks: