-
Notifications
You must be signed in to change notification settings - Fork 17
Tests speedup #4084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests speedup #4084
Conversation
ea4a7bd to
f0fb111
Compare
f0fb111 to
34c2a4f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4084 +/- ##
=======================================
Coverage 46.47% 46.47%
=======================================
Files 123 123
Lines 28902 28902
=======================================
Hits 13432 13432
Misses 15470 15470 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I will perform a full review later, but I have one comment about the scope of #2901. Are we only considering unit tests to be within the scope of the issue? Our integration tests are also very useful to run locally when making changes outside of unit tested models, however they are pretty slow. Is there a separate issue for the integration tests> |
|
Heres the tests slower than 1s on my laptop split into the three categories that hit that barrier. To me only the examples and the first regression could be considered a long time for the type of 'tests' they are (possibly the plot_proc test in integration). Integrations locally take 1m8s which i dont think is that long personally for integration style testing. Examples: Integration Regression |
|
Thanks for checking, I had in my head that the integration tests were much slower but I guess splitting the examples tests out solved that. |

Description
Closes #2901
tests seemingly were slow because there was loads of data in the unit test files. The tests now run locally in under 10s
I've also done some cleanup while I was there with json file formatting (adding biome for pre-commit) and added a plotting switch to the tests to disable showing of figures unless requested.
The fixtures around plotting mean that you can optionally mark test classes and the plots will be shown after all tests in that class have run
Checklist
I confirm that I have completed the following checks: