Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4087 +/- ##
=======================================
Coverage 46.47% 46.47%
=======================================
Files 123 123
Lines 28902 28907 +5
=======================================
+ Hits 13432 13435 +3
- Misses 15470 15472 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timothy-nunn
approved these changes
Feb 10, 2026
Collaborator
timothy-nunn
left a comment
There was a problem hiding this comment.
Happy with code changes, JF happy too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new physics variable to track the average neutron flux at the plasma surface and integrates it throughout the codebase. The changes ensure this value is calculated, initialized, displayed in plots, and outputted for analysis. Here are the most important updates, grouped by theme:
Addition and Initialization of New Variable:
Added
plfux_plasma_surface_neutron_avg_mwtophysics_variables.pyand initialized it ininit_physics_variables()to enable tracking of the average neutron flux at the plasma surface.Calculation Logic:
Computed
plfux_plasma_surface_neutron_avg_mwin thephysics()method by dividing total neutron power by plasma surface area, ensuring accurate physics modeling.Output and Visualization:
plfux_plasma_surface_neutron_avg_mwto the output inoutplas()for reporting and analysis.plot_main_plasma_information()to display the new neutron flux value in plasma information plots, improving data visualizationChecklist
I confirm that I have completed the following checks: