-
Notifications
You must be signed in to change notification settings - Fork 17
972 pf power supplies accounting 2 #4089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ym1906
wants to merge
17
commits into
main
Choose a base branch
from
972-pf-power-supplies-accounting-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+438
−139
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
ede81d1
Added new variables for efficiency of pf-coil power components
ym1906 ef8d2e3
Updated the indices in loops to align with PROCESS style guide
ym1906 c1b3831
updates the dosctring of new pf power variables
ym1906 e9aaa12
Refactored pfpwr. Added new functions to calculate busbar, power supp…
ym1906 b26b4cd
Added documentation for the changes to pf power accounting
ym1906 91b22d0
Corrected unparsed variables
j-a-foster 8f51ff7
Fixed subscripts in docs
j-a-foster 5332df6
Removed unnecessary comments
ym1906 42db87e
change ngrpt to n_pf_coil groups for clarity
ym1906 0671d75
Updated index name for number of pf coils in each group
ym1906 caeecef
Updated ii index to idx_circuit
ym1906 8feead1
Updated jj index to idx_group
ym1906 6c61b06
Updated jpf to idx_pf_coil, removed id_coil_in_group
ym1906 6d5448c
Updated kk to idx_time
ym1906 5d532b3
Updated ii to idx_time_interval
ym1906 2032b8f
Updated ii to idx_circuit
ym1906 1b908dd
Updated functions and calls to use the updated indexing
ym1906 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the superscript
Tin this case?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It represents the transpose of the vector of currents