Skip to content

Conversation

@chris-ashe
Copy link
Collaborator

Description

This is a legacy issue and should be solved by #3748 . There was error checking in the output (should not be there...) that was missed in #3748 and so the $\cos\left(\frac{\pi}{N_{TF}}\right)$ has now been removed

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe chris-ashe self-assigned this Feb 10, 2026
@chris-ashe chris-ashe requested a review from a team as a code owner February 10, 2026 10:30
@chris-ashe chris-ashe added TF Coil Toroidal field coil Bug Something isnt working labels Feb 10, 2026
@timothy-nunn timothy-nunn requested a review from mkovari February 10, 2026 10:35
@timothy-nunn
Copy link
Collaborator

@mkovari you asked on the issue to be listed as a reviewer

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.47%. Comparing base (6ba13ca) to head (08efbb3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4090   +/-   ##
=======================================
  Coverage   46.47%   46.47%           
=======================================
  Files         123      123           
  Lines       28902    28901    -1     
=======================================
  Hits        13432    13432           
+ Misses      15470    15469    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@timothy-nunn timothy-nunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of the PR can you also remove the outputting into the OUT.DAT.

If the dimensions are inconsistent, it should be done with logger.error not commenting/outputs to the MFile and OUTFile. No need to do anything if they are consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isnt working TF Coil Toroidal field coil

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistency between the TF coil radial build in machine_build.f90 and sctfcoilf90

3 participants