-
-
Notifications
You must be signed in to change notification settings - Fork 99
Improves download and decompression performance #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves download and decompression performance #425
Conversation
📝 WalkthroughWalkthroughBumped JavaSteam to 1.8.0-11-SNAPSHOT; increased download/decompress ratio tiers; removed Changes
Sequence Diagram(s)(Skipped — changes do not introduce a new multi-component control flow that requires visualization) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 3 files
app/build.gradle.kts
Outdated
| implementation(files("../../JavaSteam/build/libs/javasteam-1.8.0-9-SNAPSHOT.jar")) | ||
| implementation(files("../../JavaSteam/javasteam-depotdownloader/build/libs/javasteam-depotdownloader-1.8.0-9-SNAPSHOT.jar")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what was changed? My download for Nidhogg is not even starting, it's stuck on "Calculating..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nvm, it took a minute but it started downloading eventually... Will try on a larger game
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nidhogg download still stopping at 100% and never completing, that's why we had downgraded to old version...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, it eventually finished after a long delay 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are still getting the "Requested exe is invalid" error. I think something is broken...
7ff77a3 to
34d0668
Compare
Updates JavaSteam version, download and decompress ratios to improve download performance
34d0668 to
e27b5bb
Compare
|
Nice job, downloads are way faster, verify files works beautifully <3 |
Updates JavaSteam version, download and decompress ratios to improve download performance, also fixed "Validate Files" to ensure all files matches the depot manifest.
Related change to JavaSteam:
joshuatam/JavaSteam@b1eb347
joshuatam/JavaSteam@0124cf7
Summary by cubic
Improves depot download performance by tuning concurrency and upgrading to JavaSteam 1.8.0-11-SNAPSHOT. This better uses CPU cores and reduces install time on faster connections.
Performance
Dependencies
Written for commit c340e62. Summary will update on new commits.
Summary by CodeRabbit
Chores
Refactor