You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Have other features this PR touches also been tested?
Has the code been formatted for consistency and readability?
Did you also update related documentation and tooling, such as .readme or tests?
Overview
This new feature for the API Sync module facilitates the synching of files if a configuration setting is checked. It handles imports and exports as described in the README.md. File deletions are made if the source project is empty. Logging messages are made if file transmission is successful.
Context
This PR is necessitated by an Edge for Scholars project that requires a large amount of files to be synched on a dev server.
Screenshots
To enable or disable, check the box in the module's configuration that says:
export-files: Check to export files only when the filename has changed. When exported, any files on the server will be overwritten by the new files. Exporting files can significantly increase the time required to sync a project. The holder of the API token must have Delete Record privileges on the remote server.
import-files: Check to import files only when the filename has changed. Files that you have saved will be replaced by any downloaded files. Importing files can significantly increase the amount of time required to sync a project.
@Ehaic or @moorejr5, what are your thoughts on this? Was it created to aid in something Edge For Scholars related? If so, does it make sense to review on EFS time?
@Ehaic or @moorejr5, what are your thoughts on this? Was it created to aid in something Edge For Scholars related? If so, does it make sense to review on EFS time?
It was indeed, I'll doublecheck it with Scott next Wednesday in our standard meeting. I remember him bringing it up around the time but I don't remember if he said it was ready and he wanted it checked or not.
@Ehaic or @moorejr5, what are your thoughts on this? Was it created to aid in something Edge For Scholars related? If so, does it make sense to review on EFS time?
It was indeed, I'll doublecheck it with Scott next Wednesday in our standard meeting. I remember him bringing it up around the time but I don't remember if he said it was ready and he wanted it checked or not.
It was for Ryan. I believe it has been ready for review whenever someone can review it. I'm happy to put it on EFS time. I've tested it to copy over projects with files myself.
@Ehaic@moorejr5 - any reason why this code shouldn't be pushed out?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight Checklist
Overview
This new feature for the API Sync module facilitates the synching of files if a configuration setting is checked. It handles imports and exports as described in the
README.md. File deletions are made if the source project is empty. Logging messages are made if file transmission is successful.Context
This PR is necessitated by an Edge for Scholars project that requires a large amount of files to be synched on a dev server.
Screenshots
To enable or disable, check the box in the module's configuration that says:
export-files: Check to export files only when the filename has changed. When exported, any files on the server will be overwritten by the new files. Exporting files can significantly increase the time required to sync a project. The holder of the API token must have Delete Record privileges on the remote server.import-files: Check to import files only when the filename has changed. Files that you have saved will be replaced by any downloaded files. Importing files can significantly increase the amount of time required to sync a project.