early bail out for apps without server actions #87775
Open
+85
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes server action handling by moving the hasServerActions() check to occur immediately after determining a request could potentially be a server action, before expensive operations like CSRF validation, header parsing, and body processing. This significantly reduces CPU overhead for spam requests on applications without server actions.
Key Changes
- Early bailout for apps without server actions to avoid unnecessary CPU work
- Enhanced error message when no server actions are available in the application
- Consistent use of
getActionNotFoundError()helper throughout the codebase
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change moves the hasServerActions() check to occur immediately after determining that a request could potentially be a server action, before any expensive operations like CSRF validation, header parsing, or body processing.
apps without server actions were still performing significant CPU work (CSRF checks, header parsing, etc.) when receiving spam requests that mimic server action calls, leading to high CPU usage even though no actions exist. (this was an issue in my app, and its what caused my next.js site go down. see #87771
by checking hasServerActions() early, we can immediately return a 404 for fetch actions or null for non-fetch requests, avoiding all the unnecessary processing. This significantly reduces CPU overhead for spam requests on pages that don't use server actions.