Unroll first and last iteration in encoding#545
Draft
JonasAlaif wants to merge 2 commits intomasterfrom
Draft
Conversation
This makes the `CfgTests` happy for some reason
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a
loops we can instead generate the CFG of essentially
This essentially unrolls the first and last loop iteration when executed in Silicon.
This change should be identical to viperproject/carbon#399 — i.e. we should add a flag for enabling this behavior.
The one thing I'm not sure about is the hardcoded
Inhale(cond), sometimes we might want this to be anAssume? Is there any significant difference?