Consistency checks to forbid inhale-exhale-assertions in function preconditions and predicate bodies#828
Draft
marcoeilers wants to merge 1 commit intomasterfrom
Draft
Consistency checks to forbid inhale-exhale-assertions in function preconditions and predicate bodies#828marcoeilers wants to merge 1 commit intomasterfrom
marcoeilers wants to merge 1 commit intomasterfrom
Conversation
…ion preconditions and predicate bodies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds consistency checks that forbid inhale-exhale assertions in predicate bodies and in function preconditions. Currently, Silicon raises an internal error when it encounters these (see viperproject/silicon#271), whereas Carbon just accepts them.
I think the semantics is at the very least completely unclear and probably doesn't make sense at all, which is why this PR forbids this situation for now. However, this obviously needs to be discussed first, so this PR should not be merged before it's been discussed in a Viper meeting.