Open
Conversation
BiancaNecula
added
enhancement
Jokeswar
requested changes
Oct 11, 2020
Comment on lines
+149
to
+151
| preliminary_score = models.DecimalField( | ||
| max_digits=5, decimal_places=2, null=True | ||
| ) |
Contributor
There was a problem hiding this comment.
There is no need to save it as a field. Usually, in a database we do not write redundant data - total_score is written the same way and we should change it. We could just use calculate_preliminary_score with a @property annotation (so that it can be used in a template), provided we move it in the submission model. Maybe we could also add caching (we have cachetools) - with a TTL type cache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The preliminary score is calculated with penalty for being late.
Total score is now just preliminary score +/- review score.
Fixes #257
Testing
Checklist