Open
Conversation
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
d4l3k
approved these changes
Feb 14, 2022
d4l3k
left a comment
There was a problem hiding this comment.
Seems pretty reasonable :)
It may be a tad specific to my use case but I bet someone would find it useful
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Owner
Author
|
@d4l3k my hope was I could get us started on some of the changes to auth etc. that you outlined in the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the start of work for more docs and bug fixes to address #15. I think it would be good to have a set of "helper" client functions with reggie, or if not, at least examples. I stopped adding to the docs because I want to discuss what should be reggie vs. example first.
Signed-off-by: vsoch vsoch@users.noreply.github.com