fix(runtime-vapor): correctly check slot existence in ownKeys #14252
+46
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in the
ownKeystrap of the slots proxy where accessingslot.namewould throw an error when a dynamic slot returnsundefined(e.g., when usingv-ifwith afalsecondition).Reproduction: playground
Problem
When using dynamic slots with conditional rendering (via
v-if), theownKeystrap indynamicSlotsProxyHandlerswould attempt to accessslot.namewithout first checking ifslotisundefined. This caused aTypeError: Cannot read properties of undefined (reading 'name')when callingObject.keys(slots)orReflect.ownKeys(slots)on a component instance with conditionally rendered slots.Solution
Added a null check before accessing
slot.namein theownKeystrap handler. This ensures that when a dynamic slot source function returnsundefined, it is properly skipped rather than causing an error.Testing
slots proxy ownKeys trap correctly reflects dynamic slot presencethat verifiesReflect.ownKeys(instance.slots)correctly reflects the presence/absence of dynamic slots when toggled withv-if