[FPGA] Update zero_copy_kernel sample to support IP-Authoring#11
Open
wangdi4 wants to merge 4 commits intodevelopmentfrom
Open
[FPGA] Update zero_copy_kernel sample to support IP-Authoring#11wangdi4 wants to merge 4 commits intodevelopmentfrom
wangdi4 wants to merge 4 commits intodevelopmentfrom
Conversation
tiwaria1
requested changes
Sep 21, 2023
| #if defined(IS_BSP) | ||
| Type* in_zero_copy = malloc_host<Type>(size, q.get_context()); | ||
| Type* out_zero_copy = malloc_host<Type>(size, q.get_context()); | ||
| #else |
Collaborator
There was a problem hiding this comment.
Add a comment here similar to the one in this commit: https://github.com/oneapi-src/oneAPI-samples/pull/1890/files#diff-5bf4c46164e0fe924b5cd1ed04885a6c86ebe3710e8f3a89bead31e3e9cf3c78 that motivates why buffer location must be specified for IPA flow.
Collaborator
There was a problem hiding this comment.
And add the same to buffer_kernel.hpp in the !IS_BSP clause.
tiwaria1
reviewed
Sep 21, 2023
Comment on lines
89
to
91
| // The USM pointers passed into the kernel must match with the buffer location | ||
| // of each kernel argument, i.e. the allocated host memory should be in | ||
| // the location "0", as requested in ZeroCopyKernel |
Collaborator
There was a problem hiding this comment.
Suggested change
| // The USM pointers passed into the kernel must match with the buffer location | |
| // of each kernel argument, i.e. the allocated host memory should be in | |
| // the location "0", as requested in ZeroCopyKernel | |
| // The USM pointers passed into the kernel must be allocated with the same | |
| // buffer_location as the one specified on the kernel argument with the | |
| // annotated_arg class. |
tiwaria1
approved these changes
Sep 21, 2023
wangdi4
changed the title
yuguen
approved these changes
Sep 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change updates
zero_copy_kernelsample on how the buffer locations are being selected in the sample to match the new 2024.0 IPA interfaces definitions.In
zero_copy_kernelboth accessor (requiring device allcoated memory) and USM host pointer are used. In full-system flow, the board spec has defined a device global memory and a host/shared global memory. While in IP-Authoring flow,buffer_locationshould be specified onaccessorandannotated_argso the compiler can infer global memory interfaces and generate board spec.Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration