allow users to provide their own react/react-dom versions#2
Open
FredKSchott wants to merge 1 commit intowearespindle:masterfrom
Open
allow users to provide their own react/react-dom versions#2FredKSchott wants to merge 1 commit intowearespindle:masterfrom
FredKSchott wants to merge 1 commit intowearespindle:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By defining react & react-dom as dependencies, this package will always use those outdated package versions that it marked as explicit dependencies. If you remove them as dependencies, react-ecmascript will pull from whatever versions of react & react-dom that you've installed yourself.