Skip to content

fix: remove humidity mode from OASISMIST#297

Open
EnochPrime wants to merge 2 commits intowebdjoe:masterfrom
EnochPrime:oasismist-remove-humidity
Open

fix: remove humidity mode from OASISMIST#297
EnochPrime wants to merge 2 commits intowebdjoe:masterfrom
EnochPrime:oasismist-remove-humidity

Conversation

@EnochPrime
Copy link

@EnochPrime EnochPrime commented Feb 13, 2025

Removes the humidity mode humidity from OASISMIST.

Also unintentionally auto sorted imports. Can revert if desired.

Closes #295

@webdjoe
Copy link
Owner

webdjoe commented Feb 13, 2025

What is your configModule? Oddly enough, I believe that there is one oasismist version that has a humidity option and one that doesn't

@EnochPrime
Copy link
Author

What is your configModule? Oddly enough, I believe that there is one oasismist version that has a humidity option and one that doesn't

WFON_AHM_LUH-A451S-WUS_US

@webdjoe
Copy link
Owner

webdjoe commented Feb 13, 2025

If you go to https://levoit.com/products/oasismist-smart-humidifier, does your humidifier look like the photo at the top of the page with Mist, Auto, Humidity and Warm? Or does it look like the one in the picture below that with Mist, Auto, Sleep and Warm? I don't have this unit but I've gotten conflicting comments about the humidity method, so I'm assuming there are two different versions of the same model.

@EnochPrime
Copy link
Author

If you go to https://levoit.com/products/oasismist-smart-humidifier, does your humidifier look like the photo at the top of the page with Mist, Auto, Humidity and Warm? Or does it look like the one in the picture below that with Mist, Auto, Sleep and Warm? I don't have this unit but I've gotten conflicting comments about the humidity method, so I'm assuming there are two different versions of the same model.

Mine is the one with Mist, Auto, Sleep, and Warm for controls.

@webdjoe
Copy link
Owner

webdjoe commented Feb 13, 2025

@cdnninja @iprak the OasisMist 4.5L has different devices based on configModule

@cdnninja
Copy link
Contributor

Right now I believe the core code uses the modes that come from this library. Do you mean a third type exists that isn't defined?

@webdjoe
Copy link
Owner

webdjoe commented Feb 13, 2025

No - the OasisMist model has one model that has Mist, Auto, Sleep, and Warm and one that has Mist, Auto, Humidity and Warm. I'm not sure what the difference between humidity and auto is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid humidity mode for LUH-O451S-WUS (Oasismist)

3 participants