Initial support for webpack@2. #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is obviously a breaking change because of the changes to the webpack API. Smoke tests have been added to ensure it works in the most basic of cases. `postcss-import` is pinned to `8.1.0` because of a breaking bug with `webpack@2`. See: postcss/postcss-import#207. Support for `node@0.12` is removed because `webpack@2` does not support it.
izaakschroeder
force-pushed
the
webpack2
branch
from
4552e55 to
e6d4efc
Compare
This was referenced Oct 7, 2016
baer
reviewed
Oct 19, 2016
| # Use GCC 4.8 if it's available | ||
| - 'if [ ! `which gcc-4.8` == "" ]; then export CXX=g++-4.8 && export CC=gcc-4.8; fi' | ||
| - node_js: 4 | ||
| - node_js: 5 |
| styleLoader, | ||
| `${pack(cssLoader, config)}!${loader}` | ||
| ); | ||
| return [plugin.loader({omit: 1, remove: true}), { |
| }), | ||
| ...(Array.isArray(options) ? options : options(webpack)), | ||
| autoprefixer({ | ||
| browsers: ['last 2 versions'], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is obviously a breaking change because of the changes to the webpack API. Smoke tests have been added to ensure it works in the most basic of cases.
postcss-importis pinned to8.1.0because of a breaking bug withwebpack@2. See: postcss/postcss-import#207.With
webpack@2locking down properties on theloaderobject it's no longer possible to merge "same" loaders withwebpack-partial.Support for
node@0.12is removed becausewebpack@2does not support it.See:
optionsto children. webpack-contrib/extract-text-webpack-plugin#266optionsviaquery. webpack/postcss-loader#104/cc @nealgranger @baer