Conversation
Contributor
|
@WofWca there are conflicts :( |
Member
Author
|
Will rebase now. |
WofWca
force-pushed
the
wofwca/nativify-dialog
branch
from
cbcd1e2 to
a287623
Compare
Member
Author
|
CI is failing because of #127 Also I just found an issue with this where the dialog doesn't take full width if the content is narrow. Let me fix that. |
WofWca
force-pushed
the
wofwca/nativify-dialog
branch
2 times, most recently
from
30d1b82 to
8a58e39
Compare
Contributor
|
there seems to be still some linter warnings |
Most importantly, this allows closing the dialog with Escape. A (positive?) side effect is that in the dark theme when opening the dialog we will darken the background instead of lightening it. I have tested this on narrow screens and wide screens, comparing side-by-side with the original version. Everything should look almost the same, maybe except for the backdrop. This also fixes a small issue where the contents outside the dialog were keyboard-interactive.
WofWca
force-pushed
the
wofwca/nativify-dialog
branch
from
8a58e39 to
ba880f6
Compare
Member
Author
|
JS, CSS, HTML clear now |
adbenitez
approved these changes
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most importantly, this allows closing the dialog with Escape.
A (positive?) side effect is that in the dark theme
when opening the dialog
we will darken the background instead of lightening it.
I have tested this on narrow screens and wide screens,
comparing side-by-side with the original version.
Everything should look almost the same, maybe except
for the backdrop.
This also fixes a small issue where the contents outside the dialog
were keyboard-interactive.