-
Notifications
You must be signed in to change notification settings - Fork 16
Update to sizeDist.m #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joefinlon
wants to merge
58
commits into
weiwu5:master
Choose a base branch
from
joefinlon:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inclusion of GPM GV parameters; improvements to time-dependent inter-arrival time threshold, Nt, syncing of flight time with particle time
Inclusion of GPM GV parameters; improvements to time-dependent inter-arrival time threshold, Nt, syncing of flight time with particle time
Inclusion of GPM GV parameters; improvements to time-dependent inter-arrival time threshold, Nt, syncing of flight time with particle time
Improved calculation of 'Time_in_seconds' variable for HVPS/2DS probes using the TAS from the aircraft data file.
Ignoring 'Particle_count', 'TotalPC1', and 'TotalPC2' for PMS probes as these cannot be read or derived w/ these probes.
Using 05 December 2015 OLYMPEX flight as sample dataset.
Also added compiled version of minimum enclosing circle script for use w/ Linux systems.
Will be appending to this manual.
Minor bug fixes and additions
Updated version of the python wrapper script. Allows for command line arguments - eliminates need for multiple wrappers per case.
Example batch script and matlab wrappers added.
Improved PECAN-specific PIP probe time offset correction. Added DMT-specific corrupt record identification and logging (seen during PECAN).
Moved print of status every 1000 1-sec periods earlier in code (out of conditional statement)
Modified PECAN sizeDist wrapper to work properly with parent python wrapper.
Minor changes to reflect matlab version change and directory structure
Confirmed new variable types for output file.
imgProc/sizeDist bug fixes and additions -- Addition of new example wrappers
Also added developer/contributer list
Modified time conversion scripts to cast inputs to double. Inputs as integers causes unintended results.
Added all variations of corrupt DMT boundaries to be checked. Added prints in sizeDist to ensure user knows if multiple-day time correction is applied.
Modified corrupt boundary identification to find all cases seen during PECAN. Also came up with a far cleaner process.
Mods to prevent script failure if particle reacceptance is enabled when shatter removal is disabled.
Includes original C++ files and thier Linux Matlab wrapper equivalent.
1. Zero-image particles: now continues through buffer if a rare condition is met 2. Changes to milliseconds & microsec particle timing for 2DC/2DP 3. Added support for buffer overload time w/ 2DC/2DP; appropriate SV adjustments
Added PECAN-specific flags to corrupt boundary identification to prevent errors with other probes/projects where this issue was not observed.
Fix of poorly merged sizeDist.m
- Fixed PECAN-specific corrupt record identification that prevented code to run for other projects - Removed unnecessary 'else' statement immediately following the data integrity statement block
- Moved all minimal working example materials into their own directory (named ‘minimal_working_example’) - imgProc_sm: Changed particle overload var type to ‘double’ to work with 2DC/2DP data - intArrAnalysis: Changed data type for date vector for plotting purposes
…tion - sizeDist: Implemented user argument for handling how inter-arrival time thresholds are implemented - sizeDist: Moved toggles for processing aspect ratio info and saving of info for rejected particles, inter-arrival times, and sample volume up to the user input arguments - hhmmss2insec: Changed ingested arguments to double precision to fix rare issue in sizeDist - Updated README manual
- imgProc: Added support for Fast2DC (64 diode array) - imgProc: Moved iRectEllipse and iCalcAllDiodeStats to input parameters - imgProc: Added software preamble printed statements
- read_binary_PMS: Improved image filename creation if a directory is specified in the ‘outfilename’ input argument
- read_binary_PMS: Changed netCDF data types to save space and improve write times - read_binary_PMS: Fixed rare instance where data was not saved to file - read_binary_DMT: Changed netCDF data types to save space and improve write times - imgProc_sm: Minor corrections to Fast2DC implementation from previous update - imgProc_sm: Addresses handling of 2DS clock time when the TAS is a NaN value - IntArrAnalysis: Added support for the Fast2DC probe - intArrAnalysis: Improved filename conventions for 2DS H and V channels - intArrAnalysis: Improved handling of time for 2D histogram plots - sizeDist: Added support for the max TAS values w/ Fast2DC - sizeDist: Added support for SOCRATES defaults; improved handling of inter-arrival times for Fast2DC - sizeDist: Addresses rare issue w/ particle reacceptance at very end of flight - sizeDist: Addresses issue where a flight data file spans multiple days but sampled particles do not
- sizeDist: Added support for adjusting the TAS when NaN values are encountered
- read_binary_DMT: Removed diagnostic routines that detected and attempted to correct corrupted particle slices - Transferred most of the repository's documentation over to the wiki
Corrected units attribute for effective radius in output netCDF file.
Fixed effective radius units attribute
This update drastically reduces the size of netCDF files and contains bug fixes and enhancements. -**read\_binary\_SPEC:** Compression of netCDF file variables -**imgProc\_sm:** Compression of netCDF file variables -**imgProc\_sm:** Added GCPEx-specific CIP time offset correction for many flights -**imgProc\_sm:** GCPEx CIP corrupt record identification/removal now the default -**imgProc\_sm:** Added computation of inter-arrival time for first particle in each CIP/PIP buffer -**sizeDist:** Compression of netCDF file variables -**sizeDist:** More robust detection of particles spanning multiple days -**sizeDist:** Improved detection of first particle for each second of flight if corrupted particles are present -**sizeDist:** Modified particle length/width precision for use in some Dmax definitions -**sizeDist:** Improved detection of the end of particle-specific data -**sizeDist:** Fixed data structure of 3 variables during netCDF export
- Updated a couple of helper scripts that weren’t executing properly from the last software update - Updated README file w/ revised developer list and reference to CGAL dependency - sizeDist: Fixed area-equivalent SD calculation
- read_binary_SPEC: Improvements in handling instances when probe TAS is incorrect - imgProc_sm: Improvements to hollow particle identification - holroyd: Fine detail ratio parameter now output - calculate_reject_unified: Bug fixes and improved code efficiency Co-Authored-By: weiwu5 <willwuwork@gmail.com>
- Updated the minimum working example - Updated the readme
-**read\_binary\_SPEC:** Changed how the optional flight time and true airspeed are read ingested -**imgProc\_sm:** Changed how the optional flight time and true airspeed are read ingested -**sizeDist:** Added support for 1-Hz inter-arrival time thresholds -**sizeDist:** Added probe-specific defaults for the IMPACTS campaign -**version.txt:** Contains the version software number to be outputted as metadata for the image, particle, and size distribution data -**minimum\_working\_example:** Changed how the optional flight time and true airspeed are read ingested
-**read\_binary\_SPEC:** Clarified comment in the preamble
- **read\_binary\_SPEC**: Ensures the hour timestamp is less than 24 when saving to file
- **read\_binary\_SPEC:** Minor fix to the global attributes
*sizeDist:* Added cautionary print statements when SPEC dead time > 0.8 s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for having 4 commits to this pull request...I added a couple of comments to the file after the initial upload.