Fix Windows LSP initialization error caused by backslash paths#27
Draft
kjanat wants to merge 3 commits intowingyplus:mainfrom
Draft
Fix Windows LSP initialization error caused by backslash paths#27kjanat wants to merge 3 commits intowingyplus:mainfrom
kjanat wants to merge 3 commits intowingyplus:mainfrom
Conversation
On Windows, absolute paths use backslashes, which can be misinterpreted by PowerShell scripts or commands expecting Unix-style forward-slash paths. This change normalizes the Language Server Protocol (LSP) path by replacing backslashes with forward slashes, ensuring compatibility and resolving an initialization error on Windows.
Updates the PowerShell extension to use more idiomatic Rust patterns: - Replaces `map_or` with `is_ok_and` for clearer file existence checks - Uses `ok_or` instead of `ok_or_else` for static error messages (avoiding unnecessary closure allocations) - Removes an unnecessary reference when setting the installation status Applied: cargo clippy --fix --lib -p powershell
Updates the `zed_extension_api` from v0.2.0 to v0.7.0, along with other related dependencies. This change addresses a language server initialization issue. The extension version is also bumped to 0.3.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a language server initialization error on Windows where PowerShell Editor Services failed to start due to backslashes in absolute paths being misinterpreted as escape characters.
Problem
On Windows, the extension was passing absolute paths with backslashes (e.g.,
C:\Users\...) to PowerShell commands. PowerShell interprets backslashes as escape characters, causing errors like:Full error
Solution
zed_extension_apifrom v0.2.0 to v0.7.0Changes
language_server_path()method (src/powershell.rs)Testing
Tested on Windows with PowerShell 7 where the language server now initializes successfully without path-related errors.