[WIP] Rewrite ByPropertyIdArray

[Benestar]

This should replace ByPropertyIdArray. Just a draft for now, needs lots of testing to make sure it actually replicates the behaviour of the old version of the class. However, I'm already quite proud of using only half as much codes as the old implementation.

[JeroenDeDauw]

\o/

[JeroenDeDauw]

So you are going for a class that does the same thing? I'd rather see property id based indexing, grouping and move logic be kept separate. As per #22, having a StatementGroup object or so is probably a good way to move forward with that. You'd be able to move statements within the group, and be able to move the group in the list of groups.

[Benestar]

Actually I want to keep ByPropertyIdGrouper as simple as possible and not add any move logic into it. Furthermore I'm not sure how we can do this in another class more cleanly.

One suggestion would be to pass two indices, one of the property group and one inside the group but this would require changes in the javascript ui.

[JeroenDeDauw]

You could have the move logic for a statement within a group in StatementGroup and the logic for moving a group in a list of groups in StatementGroupList. And if a StatementGroupList contains instances of StatementGroup, and allows for only one group per property, then the rules of the domain are actually enforced properly.

[Benestar]

Would this StatementGroupList then replace the current StatementList?

[Benestar]

To avoid confusion, this is going to replace ByPropertyIdArray before the WIP is removed from the topic.

[JeroenDeDauw]

Would this StatementGroupList then replace the current StatementList?

In some places it will.

[JeroenDeDauw]

Also note that moving logic was added to ReferenceList at some point

[Benestar]

@JeroenDeDauw @thiemowmde is it worth to work on this PR again or are there already alternatives to ByPropertyIdArray?

[JeroenDeDauw]

There is the ByPropertyIdGrouper that you created... no further work has been done in this direction IIRC

[thiemowmde]

I find this class scary, before and after the rewrite. I will not spend time on this.

[Benestar]

New approach made in #479