Skip to content

Conversation

@guillon
Copy link
Member

@guillon guillon commented Jan 16, 2026

Motivation

Disallow merge commit for PR. This avoids in particular typical errors such as updating the branch with a merge commit from main instead of rebasing.

Description

This is a CI check, as there is no possibility to do it with github rules, inspired from solution proposed here: https://github.com/orgs/community/discussions/12032#discussioncomment-13210015

The github settings can't be set easily to forbid merge commit on the branch update button (ref there https://github.com/orgs/community/discussions/12032).

Also, anyway it would not check merge done manually by the user, hence a pre-merge check.

@guillon guillon force-pushed the dev/cguillon/ci-merge branch 2 times, most recently from c4d7aa1 to d7a78e7 Compare January 16, 2026 11:47
@guillon guillon force-pushed the dev/cguillon/ci-merge branch 2 times, most recently from f1f5741 to 985e40f Compare January 16, 2026 11:55
@guillon guillon marked this pull request as ready for review January 30, 2026 20:15
@guillon guillon requested a review from qaco January 30, 2026 20:15
@guillon guillon self-assigned this Jan 30, 2026
@guillon guillon added the testing Add more test or rework in tests label Jan 30, 2026
@qaco qaco merged commit bc2bce8 into xtc-tools:main Jan 30, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Add more test or rework in tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants