Branch protection rules support #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pport - Fix allow_admin_bypass to correctly allow/prevent admin bypass (was inverted) - Add support for GitHub rulesets with admin bypass actors (role ID 5) - Implement migration from legacy branch protection to rulesets - Add separate check/fix for cleaning up legacy protection after migration - Update CLAUDE.md with corrected configuration documentation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Added comprehensive status check validation to ensure required checks actually exist in workflow files before enforcing them in branch protection. Changes: - Add _get_available_checks_for_repo() to parse workflow YAML files and extract job names - Add _validate_required_checks() to compare required vs available checks with helpful warnings - Integrate validation into both check and fix functions - Fix _get_rulesets() to fetch full ruleset details instead of summaries (GitHub's list API returns rules: None and conditions: None) - Fix filter logic to handle conditions: None (applies to all branches) - Add debug logging for ruleset fetching and filtering - Add 9 comprehensive unit tests for validation logic Fixes: - Silent exit bug in fix_legacy_protection_cleanup (filter wasn't matching rulesets) - Missing PR rule detection (list API doesn't include full rule details) - Legacy protection cleanup now successfully removes old protection 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add status check validation and fix ruleset API handling
Added comprehensive status check validation to ensure required checks
actually exist in workflow files before enforcing them in branch protection.
Changes:
(GitHub's list API returns rules: None and conditions: None)
Fixes:
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com