Open
Conversation
- graceful exit for all servers - Dockerfile for blocksuite (same as auth-express) - move dependencies from root package.json to demos as appropriate - use console.log for logging (didn't seem like print logging system worked and it wasn't used everywhere) - output config variables on startup (for tracing/debugging) - some renames - but could do more (I like authn for authentication and authz for authorization)
|
@beorn you shouldn't use npm install either, instead use npm ci to make use of the package-lock.json ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some questions