Update LiquidFloatingActionButton.swift#35
Open
deathslocus wants to merge 2 commits intoyoavlt:masterfrom
deathslocus:master
Open
Update LiquidFloatingActionButton.swift#35deathslocus wants to merge 2 commits intoyoavlt:masterfrom deathslocus:master
deathslocus wants to merge 2 commits intoyoavlt:masterfrom
deathslocus:master
Conversation
Added didTapped method to delegate Added didLongTapped method to LFAB and delegate
Owner
|
Thank you @deathslocus ! I totally agreed with this feature, but why do you use NSTimer instead of UILongTapGestureRecognizer? |
Author
|
Whoops forgot to unwrap the delegates. NSTimer over UILongPressGestureRecognizer mainly because it was easier for me to implement that with your existing onTapped functions, I can change it to UILongPressGestureRecognizer if you like there is no reason I have to keep it on NSTimer. Updated the fork should build now |
|
hi, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added didTapped method to delegate
Added didLongTapped method to LFAB and delegate