-
Notifications
You must be signed in to change notification settings - Fork 797
Add duration template for all function using std::chrono::milliseconds #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cacharle
wants to merge
4
commits into
zeromq:master
Choose a base branch
from
cacharle:std-chrono-any-duration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+61
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 20377959475Details
💛 - Coveralls |
d2be5ed to
79b3bd2
Compare
Contributor
Author
|
Not sure how to unit test this properly.. Is there a "check if compiles" kind of unit tests for catch2? |
gummif
requested changes
Oct 19, 2025
Member
|
To check if something compiles or not you could use C++20/23 and concept or requires expressions. |
…ce the template would be a breaking change in C++17 and bellow
01aa0b9 to
df53698
Compare
Contributor
Author
|
Fixed CI by rebasing on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the bindings slightly easier to use when dealing with durations. With the bindings handling the cast instead of the user