Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates dataset search to use an HTML-stripped description field to improve highlighting behavior.
Changes:
- Replaces
description.searchwithdescription_anchorless.searchin dataset search fields - Introduces
DATASET_SEARCH_RETURN_FIELDSto returndescription_anchorlessinstead ofdescriptionfor search - Updates dataset search service to use the new search-specific return field list
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Utils/datasetFields.js | Switches search to description_anchorless and adds a search-specific return-field list |
| Services/dataset.service.js | Uses DATASET_SEARCH_RETURN_FIELDS when generating the dataset search query |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JoonLeeNIH
had a problem deploying
to
ccdi-manager-nonprod
GitHub Actions
Failure
JoonLeeNIH
temporarily deployed
to
ccdi-manager-nonprod
GitHub Actions
Inactive
JoonLeeNIH
had a problem deploying
to
ccdi-manager-nonprod
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes search highlighting
Change Details (Specifics)
Dataset search now uses an HTML-stripped version of Dataset.description
Related Ticket(s)
https://tracker.nci.nih.gov/browse/INS-1515