London|ITP-January-2026|Alexandru Pocovnicu|Sprint 2|Form controls #943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
alexandru-pocovnicu
added
the
Needs Review
jenny-alexander
added
Review in progress
jenny-alexander
left a comment
jenny-alexander
left a comment
There was a problem hiding this comment.
You did some very good work in this PR @alexandru-pocovnicu! I added a few comments for you to review.
- I am unsure of the use of
 . Is this for formatting/styling purposes? I would avoid using this for a number of reasons: screen reader might announce each as a space and pause; it's hard for future developers to maintain; it's breaks responsive layouts.
| <footer> | ||
| <!-- change to your name--> | ||
| <h2>By HOMEWORK SOLUTION</h2> | ||
| <h3>By Alexandru Pocovnicu</h3> |
There was a problem hiding this comment.
🤔 You might consider using a different HTML element for your name within the footer. Right now, having <h3> in the footer will signal to screen readers that there is something new and important in the footer (like a sub-topic). In a sense, it breaks the semantic order of the page.
jenny-alexander
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Created a fill out form using only HTML